Skip to content

Conversation

@1996fanrui
Copy link
Member

@1996fanrui 1996fanrui commented Oct 12, 2024

What is the purpose of the change

A lot of CI failures are caused by Install cert-manager. Get more details from FLINK-36513.

Brief change log

[FLINK-36513][ci] Storing the cert-manager.yaml to avoid downloading timeout

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no

@gyfora
Copy link
Contributor

gyfora commented Oct 12, 2024

I generally would prefer storing the yaml in our code base if that’s possible to avoid this but if you like this approach more then good to go from my end :)

@1996fanrui 1996fanrui force-pushed the 36513/retry-Install-cert-manager branch from 93ac39e to 6d8b60e Compare October 12, 2024 08:16
@1996fanrui 1996fanrui changed the title [FLINK-36513][ci] Introducing retry mechanism for kubectl apply cert-manager [FLINK-36513][ci] Storing the cert-manager.yaml to avoid downloading timeout Oct 12, 2024
@1996fanrui
Copy link
Member Author

Thank you for the quick review, merging~

@1996fanrui 1996fanrui merged commit 12d809a into apache:main Oct 12, 2024
233 checks passed
@1996fanrui 1996fanrui deleted the 36513/retry-Install-cert-manager branch October 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants