[FLINK-36332] Exclude kubernetes-httpclient form API module. #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The original FLINK-36332 missed a transitive dependency on
kubernetes-httpclient-okhttpvia the flink-kubernetes-operatpr-api which mean anyone choosing an alternative client ended up with both clients on the runtime classpath 😢Brief change log
Ensure only requested kubernetes-httpclient is on the runtime classpath.
Verifying this change
This change is already covered by existing tests, such as *(please describe tests)
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation