Skip to content

Conversation

@alnzng
Copy link
Contributor

@alnzng alnzng commented Oct 25, 2024

What is the purpose of the change

This PR is for fixing the name of the metric config which enables the response codes group in "Metrics and Logging" doc, to make the naming be consistent with information in "Configuration" doc.

Brief change log

  • Add operator config prefix kubernetes.operator. to make it show the full name of the config

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changes to the CustomResourceDescriptors: (no)
  • Core observer or reconciler logic that is regularly executed: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@alnzng
Copy link
Contributor Author

alnzng commented Oct 25, 2024

@gyfora A minor improvement for doc, would you mind helping take a look?

@gyfora gyfora merged commit ad8354b into apache:main Nov 2, 2024
233 checks passed
@alnzng alnzng deleted the fix-doc branch December 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants