[FLINK-36192][log] instruct how to change log level dynamically #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showuon
commented
Nov 11, 2024
showuon
force-pushed
the
FLINK-36677
branch
2 times, most recently
from
260878d to
8db1a4b
Compare
showuon
commented
Nov 11, 2024
docs/content/docs/operations/helm.md
Outdated
Comment on lines
59
to
62
| Note, you should remember to escape some special characters in your `--set` lines, for example: | ||
| ``` | ||
| helm install --set defaultConfiguration."log4j-operator\.properties"=rootLogger.level\=DEBUG flink-kubernetes-operator helm/flink-kubernetes-operator | ||
| ``` |
Member
Author
There was a problem hiding this comment.
This took me some time to figure it out. I think it'd be great if we explicitly document it.
Member
Author
mxm
reviewed
Nov 15, 2024
Contributor
mxm
left a comment
mxm
left a comment
There was a problem hiding this comment.
Thanks for the PR! We usually just restart the operator deployment in case of logging changes, but this is cleaner.
Member
Author
|
@mxm , thanks for the comments. PR updated. Please take a look again. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In the doc, we didn't explicitly instruct users how to change log level dynamically for operator/job manager/task manager. This is important for troubleshooting, and it is already built-in config in Flink core.
Brief change log
log4j-console.propertiesandlog4j-operator.propertiesin Helm, added a hint to demo how to set config to change config dynamically.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation