[hot-fix][docs] Reflect v1.20 support #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqaiser94
commented
Nov 9, 2024
| - Triggering and managing savepoints | ||
| - Handling errors, rolling-back broken upgrades | ||
| - Multiple Flink version support: v1.16, v1.17, v1.18, v1.19 | ||
| - Multiple Flink version support: v1.16, v1.17, v1.18, v1.19, v1.20 |
Contributor
Author
There was a problem hiding this comment.
To avoid confusion, I would also suggest backporting this commit to the 1.10 release branch (if that's how the 1.10 docs can be updated).
Member
There was a problem hiding this comment.
Sounds make sense, I have cherry picked it to 1.10.
Contributor
Author
|
cc @gyfora @1996fanrui (since you were involved in #869) |
1996fanrui
approved these changes
Nov 10, 2024
Member
1996fanrui
left a comment
1996fanrui
left a comment
There was a problem hiding this comment.
Thanks @fqaiser94 for the fix!
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Update docs to reflect that v1.20 is supported.
Currently this page shows that the operator only supports up to Flink v1.19.
After this change:
Verifying this change
CMIIW but my understanding is that v1.20 support was added as part of https://issues.apache.org/jira/browse/FLINK-36129 and in fact v1.20 is supported since the flink-kubernetes-operator 1.10 release. I'm assuming this was just overlooked in #869