Skip to content

Conversation

@k-wall
Copy link
Contributor

@k-wall k-wall commented Nov 11, 2024

The docker container was being run with the uid/gid arguments switched about.

What is the purpose of the change

As pointed out by https://issues.apache.org/jira/browse/FLINK-36545, when generating the OLM bundle, the container is run with uid/gid values switched around.

Brief change log

  • Correct uid/gid values used when creating the OLM bundle.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

The docker container was being run with the uid/gid arguments switched about.
Copy link
Contributor

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but as you mention on the JIRA its not clear to me why we specify the user at all

@gyfora gyfora merged commit cfcee02 into apache:main Nov 26, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants