Skip to content

Conversation

@gyfora
Copy link
Contributor

@gyfora gyfora commented Jan 17, 2025

Brief change log

Use concurrent hashmap to avoid reconciliation errors during initialization

Verifying this change

Unit test added

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: yes

Documentation

  • Does this pull request introduce a new feature? no

@gyfora
Copy link
Contributor Author

gyfora commented Jan 17, 2025

cc @tomncooper

Copy link
Contributor

@tomncooper tomncooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, out of interest what errors were you seeing?

@gyfora
Copy link
Contributor Author

gyfora commented Jan 17, 2025

LGTM, out of interest what errors were you seeing?

ConcurrentModificationExceptions during reconciliation which lead to job reconciliation errors/retries

@gyfora gyfora merged commit 4c2c90c into apache:main Jan 20, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants