Skip to content

Conversation

@luismacosta
Copy link
Contributor

@luismacosta luismacosta commented Feb 4, 2025

Hello @gyfora

Following https://issues.apache.org/jira/browse/FLINK-37179, remove priority: 0 from CRDs

Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this approach is good. These are generated classes, next time we run the mvn build, those fields will be readded unless we fix it somewhere else

@luismacosta
Copy link
Contributor Author

There is an issue raised with argo-cd argoproj/argo-cd#3889
I will close this PR
Thanks

@luismacosta luismacosta closed this Mar 5, 2025
@wwakas
Copy link

wwakas commented May 14, 2025

Any updates on this issue when using ArgoCD to deploy the operator?
It is very annoying, because app status is stuck in a sync loop, due to the "priority" (generated) fields:
image

Does someone have any workarounds? Now, I was forced to skip the CRDs installation in the Argo app and do it manually, it is a big inconvenience.

@luismacosta
Copy link
Contributor Author

luismacosta commented May 14, 2025

Hello @wwakas

My workaround was to add ignoreDifferences in the AppSet

  ignoreDifferences:
    - group: apiextensions.k8s.io
      kind: CustomResourceDefinition
      jsonPointers:
        - "/spec/versions/0/additionalPrinterColumns/0/priority"
        - "/spec/versions/0/additionalPrinterColumns[]/priority"
      jqPathExpressions:
        - ".spec.versions[].additionalPrinterColumns[].priority"

@wwakas
Copy link

wwakas commented May 14, 2025

Hello @wwakas

My workaround was to add ignoreDifferences in the AppSet

  ignoreDifferences:
    - group: apiextensions.k8s.io
      kind: CustomResourceDefinition
      jsonPointers:
        - "/spec/versions/0/additionalPrinterColumns/0/priority"
        - "/spec/versions/0/additionalPrinterColumns[]/priority"
      jqPathExpressions:
        - ".spec.versions[].additionalPrinterColumns[].priority"

Thanks a lot, seems its working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants