Skip to content

[FLINK-37320] [Observer] FINISHED finite streaming jobs incorrectly being set to RECONCILING #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[FLINK-37320] [Observer] FINISHED finite streaming jobs incorrectly being set to RECONCILING #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...apache/flink/kubernetes/operator/observer/deployment/AbstractFlinkDeploymentObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ protected void observeJmDeployment(FlinkResourceContext<FlinkDeployment> ctx) {
}

deploymentStatus.setJobManagerDeploymentStatus(JobManagerDeploymentStatus.MISSING);
deploymentStatus.getJobStatus().setState(JobStatus.RECONCILING);

if (!ReconciliationUtils.isJobInTerminalState(deploymentStatus)) {
deploymentStatus.getJobStatus().setState(JobStatus.RECONCILING);
Copy link
Contributor

@gyfora gyfora Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test to guard this change against accidental future regressions?

Copy link
Contributor Author

@luca-p-castelli luca-p-castelli Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done. Happy to make any other changes.

}

if (previousJmStatus != JobManagerDeploymentStatus.MISSING
&& previousJmStatus != JobManagerDeploymentStatus.ERROR) {
Expand Down
22 changes: 22 additions & 0 deletions ...ava/org/apache/flink/kubernetes/operator/observer/deployment/ApplicationObserverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,4 +876,26 @@ public void validateLastReconciledClearedOnInitialFailure() {
observer.observe(deployment, TestUtils.createEmptyContext());
assertTrue(reconStatus.isBeforeFirstDeployment());
}

@Test
public void jobStatusNotOverwrittenWhenTerminal() throws Exception {
Configuration conf =
configManager.getDeployConfig(deployment.getMetadata(), deployment.getSpec());
flinkService.submitApplicationCluster(deployment.getSpec().getJob(), conf, false);
bringToReadyStatus(deployment);

deployment
.getStatus()
.getJobStatus()
.setState(org.apache.flink.api.common.JobStatus.FINISHED);

// Simulate missing deployment
var emptyContext = TestUtils.createEmptyContext();
deployment.getStatus().setJobManagerDeploymentStatus(JobManagerDeploymentStatus.MISSING);
observer.observe(deployment, emptyContext);

assertEquals(
org.apache.flink.api.common.JobStatus.FINISHED,
deployment.getStatus().getJobStatus().getState());
}
}