[FLINK-37372] Fix infinite loop bug in savepoint error handling #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afedulov
reviewed
Feb 24, 2025
...rnetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/ExceptionUtils.java
Show resolved
Hide resolved
afedulov
approved these changes
Feb 24, 2025
csviri
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A bug in the ExceptionUtils#findThrowableSerializedAware can cause it to enter an infinite loop if it cannot deserialize the SerializedThrowable error.
This affects the Kubernetes operator and can cause it to hang indefinitely.
Brief change log
Verifying this change
Unit test added
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation
no