Skip to content

Conversation

@gyfora
Copy link
Contributor

@gyfora gyfora commented Mar 26, 2025

What is the purpose of the change

During the change to the snapshot resource logic we removed the logic that adds the upgrade savepoints to the old savepoint info status field and history. This causes inconsistencies for those who are still using that feature.

Brief change log

Simply record upgrade savepoint in deprecated savepoint info to keep consistent

Verifying this change

Unit tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: yes

Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyfora gyfora merged commit 0e65a5a into apache:main Mar 28, 2025
121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants