Skip to content

[FLINK-37562] Do not check all JM replicas in observer #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

[FLINK-37562] Do not check all JM replicas in observer #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...apache/flink/kubernetes/operator/observer/deployment/AbstractFlinkDeploymentObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import io.fabric8.kubernetes.api.model.PodList;
import io.fabric8.kubernetes.api.model.apps.Deployment;
import io.fabric8.kubernetes.api.model.apps.DeploymentCondition;
import io.fabric8.kubernetes.api.model.apps.DeploymentSpec;
import io.fabric8.kubernetes.api.model.apps.DeploymentStatus;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -117,11 +116,11 @@ protected void observeJmDeployment(FlinkResourceContext<FlinkDeployment> ctx) {
ctx.getJosdkContext().getSecondaryResource(Deployment.class);
if (deployment.isPresent()) {
DeploymentStatus status = deployment.get().getStatus();
DeploymentSpec spec = deployment.get().getSpec();
if (status != null
&& status.getAvailableReplicas() != null
&& spec.getReplicas().intValue() == status.getReplicas()
&& spec.getReplicas().intValue() == status.getAvailableReplicas()
// One available JM is enough to run the job correctly
&& status.getReplicas() > 0
&& status.getAvailableReplicas() > 0
&& ctx.getFlinkService().isJobManagerPortReady(ctx.getObserveConfig())) {

// typically it takes a few seconds for the REST server to be ready
Expand Down
4 changes: 2 additions & 2 deletions flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,15 @@ public static Deployment createDeployment(boolean ready) {
String nowTs = Instant.now().toString();
var status = new DeploymentStatus();
status.setAvailableReplicas(ready ? 1 : 0);
status.setReplicas(1);
status.setReplicas(2);
var availableCondition = new DeploymentCondition();
availableCondition.setType("Available");
availableCondition.setStatus(ready ? "True" : "False");
availableCondition.setLastTransitionTime(nowTs);
status.setConditions(List.of(availableCondition));

DeploymentSpec spec = new DeploymentSpec();
spec.setReplicas(1);
spec.setReplicas(3);

var meta = new ObjectMeta();
meta.setCreationTimestamp(nowTs);
Expand Down