[FLINK-37662][helm] Support init and side car containers #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyfora
reviewed
May 1, 2025
| jvmArgs: | ||
| webhook: "" | ||
| operator: "" | ||
| operatorLog: "-Dlog4j.configurationFile=/opt/flink/conf/log4j-operator.properties" |
Contributor
There was a problem hiding this comment.
Could the log args be simply part of jvmArgs.operator? (Although that may be a breaking change)
Contributor
Author
There was a problem hiding this comment.
entry point simply combines them for both operator and webhook: $LOG_CONFIG $JVM_ARGS
however moving the log default to jvmArgs.operator and jvmArgs.webhook would introduce duplication and not be compatible with existing usage of those settings (log settings would be lost for everyone that uses jvmArgs currently.
morhidi
reviewed
May 5, 2025
| value: /opt/flink/plugins | ||
| - name: LOG_CONFIG | ||
| value: -Dlog4j.configurationFile=/opt/flink/conf/log4j-operator.properties | ||
| value: {{ .Values.jvmArgs.operatorLog }} |
Contributor
There was a problem hiding this comment.
shouldn't this be .Values.jvmArgs.operatorLogConfig or .Values.jvmArgs.logConfig
Contributor
Author
There was a problem hiding this comment.
@morhidi renamed to logConfig, assuming it should be shared.
mxm
approved these changes
May 5, 2025
morhidi
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customization points for init and side car containers to the helm chart, which are common in non-trivial deployments.