Skip to content

Conversation

@csviri
Copy link
Contributor

@csviri csviri commented May 21, 2025

What is the purpose of the change

To update the to the most recent version of JOSDK (5.1)

Brief change log

  • Updated to JOSDK v5
  • In some places UpdateControl.updateResource is replaced by UpdateControl.patchResource.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): tes
  • The public API, i.e., is any changes to the CustomResourceDescriptors: Theoretically yes
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

csviri added 9 commits May 19, 2025 17:39
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java 11 -> 17 upgrade requirement for the operator must be discussed on the Flink Mailing list before this is merged

csviri added 2 commits May 28, 2025 10:56
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested a review from gyfora May 29, 2025 07:27
InformerConfiguration<FlinkSessionJob> configuration =
InformerConfiguration.from(FlinkSessionJob.class, context)
var configuration =
InformerEventSourceConfiguration.from(FlinkSessionJob.class, FlinkSessionJob.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be InformerEventSourceConfiguration.from(FlinkSessionJob.class, FlinkDeployment.class) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, good catch, thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this worked in our e2es or if we are missing some key test coverage :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not, it is just used for the default secondayr to primary mapper. So actually the API might be on JOSDK side. So this is not a mandatory field.

Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I had a minor comment/question

Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested a review from gyfora June 2, 2025 09:15
@csviri csviri changed the title Upgrade to JOSDK 5.1 [FLINK-37885] Upgrade to JOSDK 5.1 Jun 3, 2025
@gyfora gyfora merged commit a3f14ef into apache:main Jun 3, 2025
121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants