Skip to content

FLINK-38449: Makes error message for fractional values for MemorySize explicit #27056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+31 −0
Open

FLINK-38449: Makes error message for fractional values for MemorySize explicit #27056

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6661f49
Makes error message for fractional values for MemorySize explicit
Sep 27, 2025
f5d8581
Use regex
Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flink-core-api/src/main/java/org/apache/flink/configuration/MemorySize.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,10 @@ public static long parseBytes(String text) throws IllegalArgumentException {
throw new NumberFormatException("text does not start with a number");
}

if(unit.startsWith(".")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this to test the valid characters allowed - maybe with one or more regex's. I assume the unit should be 1 or more digits followed by a supported unit characters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the unit is 1 or more digits followed by unit. I have changed this to use a regex. Could you take another look? Thanks!

throw new IllegalArgumentException("Memory size must be an integer value. Fractional values are not supported. Found: " + text);
}

final long value;
try {
value = Long.parseLong(number); // this throws a NumberFormatException on overflow
Expand Down
4 changes: 4 additions & 0 deletions flink-core-api/src/test/java/org/apache/flink/configuration/MemorySizeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ void testParseInvalid() {
// negative number
assertThatThrownBy(() -> MemorySize.parseBytes("-100 bytes"))
.isInstanceOf(IllegalArgumentException.class);

// fractional number
assertThatThrownBy(() -> MemorySize.parseBytes("1.5g"))
.isInstanceOf(IllegalArgumentException.class);
}

@Test
Expand Down