[FLINK-38387][build] Disable spotless for java 25 #27079
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Oct 8, 2025
| Re-evaluate once support for Java 11 is dropped. --> | ||
| <skip>true</skip> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
I see that java 21 has compilerArgs, I am curious, is this missing for java 25 or do we no longer need them at this level?
There was a problem hiding this comment.
there is no compiler args for profile java21
you probably mean profile java21-target then it is different
there is a separate PR to add java25-target with such flags #27080
this PR is only about disabling spotless
github-actions
bot
added
the
community-reviewed
davidradl
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The problem with spotless in jdk25 is that we still use google-java-format 1.24.0 which still supports jdk11.
The first google-java-format supporting jdk25 is 1.28.0 however it already requires jdk17 as minimum and doesn't support jdk11. So there is no way for now to support 11, 17, 21 and 25. Moreover updating of google-java-format will also trigger a bit different format for some edge cases. Thus the approach is as before: disable it for jdk25 for now
Brief change log
pom
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation