Skip to content

[FLINK-38387][build] Disable spotless for java 25 #27079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −0
Open

[FLINK-38387][build] Disable spotless for java 25 #27079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,41 @@ under the License.
</build>
</profile>

<profile>
<id>java25</id>
<activation>
<jdk>[25,)</jdk>
</activation>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludedGroups>
${surefire.excludedGroups.github-actions},
${surefire.excludedGroups.adaptive-scheduler},
${surefire.excludedGroups.jdk},
</excludedGroups>
</configuration>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<configuration>
<!-- Current google format does not run on Java 25.
Don't upgrade it in this profile because it formats code differently.
Re-evaluate once support for Java 11 is dropped. -->
<skip>true</skip>
</configuration>
</plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that java 21 has compilerArgs, I am curious, is this missing for java 25 or do we no longer need them at this level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no compiler args for profile java21

you probably mean profile java21-target then it is different

there is a separate PR to add java25-target with such flags #27080

this PR is only about disabling spotless

</plugins>
</pluginManagement>
</build>
</profile>

<profile>
<id>fast</id>
<activation>
Expand Down