Skip to content

fix append hang #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luoyuxia merged 2 commits into from
Jan 7, 2026
Merged

fix append hang #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e48fc9
fix append hang
Jan 6, 2026
aa0dc2b
address comments
Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 26 additions & 24 deletions crates/fluss/src/client/write/accumulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,34 +299,36 @@ impl RecordAccumulator {
.batches
.get(&table_bucket.bucket_id())
{
let mut batch = {
let mut maybe_batch = None;
{
let mut batch_lock = deque.lock().await;
if batch_lock.is_empty() {
continue;
if !batch_lock.is_empty() {
let first_batch = batch_lock.front().unwrap();

if size + first_batch.estimated_size_in_bytes() > max_size as i64
&& !ready.is_empty()
{
// there is a rare case that a single batch size is larger than the request size
// due to compression; in this case we will still eventually send this batch in
// a single request.
break;
}

maybe_batch = Some(batch_lock.pop_front().unwrap());
}
let first_batch = batch_lock.front().unwrap();

if size + first_batch.estimated_size_in_bytes() > max_size as i64
&& !ready.is_empty()
{
// there is a rare case that a single batch size is larger than the request size
// due to compression; in this case we will still eventually send this batch in
// a single request.
break;
}

batch_lock.pop_front().unwrap()
};
}

let current_batch_size = batch.estimated_size_in_bytes();
size += current_batch_size;
if let Some(mut batch) = maybe_batch {
let current_batch_size = batch.estimated_size_in_bytes();
size += current_batch_size;

// mark the batch as drained.
batch.drained(current_time_ms());
ready.push(Arc::new(ReadyWriteBatch {
table_bucket,
write_batch: batch,
}));
// mark the batch as drained.
batch.drained(current_time_ms());
ready.push(Arc::new(ReadyWriteBatch {
table_bucket,
write_batch: batch,
}));
}
}
}
if current_index == start {
Expand Down
Loading