-
Notifications
You must be signed in to change notification settings - Fork 478
[flink] Refactor CALL procedure "sys.xxx_cluster_config" to support multiple conifg keys #2279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
...k-common/src/main/java/org/apache/fluss/flink/procedure/ResetClusterConfigsProcedure.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.flink.procedure; | ||
|
|
||
| import org.apache.fluss.config.cluster.AlterConfig; | ||
| import org.apache.fluss.config.cluster.AlterConfigOpType; | ||
|
|
||
| import org.apache.flink.table.annotation.ArgumentHint; | ||
| import org.apache.flink.table.annotation.DataTypeHint; | ||
| import org.apache.flink.table.annotation.ProcedureHint; | ||
| import org.apache.flink.table.procedure.ProcedureContext; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Procedure to reset cluster configurations to their default values. | ||
| * | ||
| * <p>This procedure reverts the configurations to their initial system defaults. The changes are: | ||
| * | ||
| * <ul> | ||
| * <li>Validated by the CoordinatorServer before persistence | ||
| * <li>Persisted in ZooKeeper for durability | ||
| * <li>Applied to all relevant servers (Coordinator and TabletServers) | ||
| * <li>Survive server restarts | ||
| * </ul> | ||
| * | ||
| * <p>Usage examples: | ||
| * | ||
| * <pre> | ||
| * -- reset a configuration | ||
| * CALL sys.reset_cluster_configs('kv.rocksdb.shared-rate-limiter.bytes-per-sec'); | ||
| * | ||
| * -- reset multiple configurations at one time | ||
| * CALL sys.reset_cluster_configs('kv.rocksdb.shared-rate-limiter.bytes-per-sec', 'datalake.format'); | ||
| * | ||
| * </pre> | ||
| * | ||
| * <p><b>Note:</b> In theory, an operation like <b>Reset to default value</b> should always succeed, | ||
| * as the default value should be a valid one | ||
| */ | ||
| public class ResetClusterConfigsProcedure extends ProcedureBase { | ||
|
|
||
| @ProcedureHint( | ||
| argument = {@ArgumentHint(name = "config_keys", type = @DataTypeHint("STRING"))}, | ||
| isVarArgs = true) | ||
| public String[] call(ProcedureContext context, String... configKeys) throws Exception { | ||
| try { | ||
| // Validate config key | ||
| if (configKeys.length == 0) { | ||
| throw new IllegalArgumentException( | ||
| "config_keys cannot be null or empty. " | ||
| + "Please specify valid configuration keys."); | ||
| } | ||
|
|
||
| List<AlterConfig> configList = new ArrayList<>(); | ||
| List<String> resultMessage = new ArrayList<>(); | ||
|
|
||
| for (String key : configKeys) { | ||
| String configKey = key.trim(); | ||
| if (configKey.isEmpty()) { | ||
| throw new IllegalArgumentException( | ||
| "Config key cannot be null or empty. " | ||
| + "Please specify a valid configuration key."); | ||
| } | ||
|
|
||
| String operationDesc = "deleted (reset to default)"; | ||
|
|
||
| AlterConfig alterConfig = | ||
| new AlterConfig(configKey, null, AlterConfigOpType.DELETE); | ||
| configList.add(alterConfig); | ||
| resultMessage.add( | ||
| String.format( | ||
| "Successfully %s configuration '%s'. ", operationDesc, configKey)); | ||
| } | ||
|
|
||
| // Call Admin API to modify cluster configuration | ||
| // This will trigger validation on CoordinatorServer before persistence | ||
| admin.alterClusterConfigs(configList).get(); | ||
|
|
||
| return resultMessage.toArray(new String[0]); | ||
| } catch (IllegalArgumentException e) { | ||
| // Re-throw validation errors with original message | ||
| throw e; | ||
| } catch (Exception e) { | ||
| // Wrap other exceptions with more context | ||
| throw new RuntimeException( | ||
| String.format("Failed to reset cluster config: %s", e.getMessage()), e); | ||
| } | ||
| } | ||
| } | ||
128 changes: 0 additions & 128 deletions
128
...link-common/src/main/java/org/apache/fluss/flink/procedure/SetClusterConfigProcedure.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment description should be updated. In theory, an operation like "Reset to default value" should always succeed, as the default value should be a valid one.