[helm] Allow templating listeners (internal, client) from values#2460
Merged
polyzos merged 2 commits intoapache:mainfrom Feb 6, 2026
Merged
[helm] Allow templating listeners (internal, client) from values#2460polyzos merged 2 commits intoapache:mainfrom
polyzos merged 2 commits intoapache:mainfrom
Conversation
affo
suggested changes
Jan 23, 2026
affo
left a comment
There was a problem hiding this comment.
Thank you!
Multiple comments added.
I would also add, that it would also be nice to also configure the security protocol map as part of this PR.
As we would allow to template listeners, one can decide for the port, as well as the security protocol.
Contributor
Author
|
Thanks @affo, I have addressed your findings. I will introduce the external access support in the follow up PR. For the security map, let's discuss it once we have PR for enabling security (e.g, SASL) protocol in the helm charts 🤝 |
Contributor
|
Hi, @loserwang1024. Could you take a look at this pr? |
|
@loserwang1024 I don't have any permission to merge, do you have? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2459
Brief change log
Adds templating for listeners in the values file
Tests
NA
API and Format
NA
Documentation
Updated for listeners configuration options.