Skip to content

[lake/tiering] add bytes written tracking and metrics for tiering service#2933

Open
beryllw wants to merge 2 commits intoapache:mainfrom
beryllw:tiering-fluss-read-metrics
Open

[lake/tiering] add bytes written tracking and metrics for tiering service#2933
beryllw wants to merge 2 commits intoapache:mainfrom
beryllw:tiering-fluss-read-metrics

Conversation

@beryllw
Copy link
Copy Markdown
Contributor

@beryllw beryllw commented Mar 25, 2026

…jobs

Purpose

Linked issue: close #2932

Brief change log

Tests

API and Format

Documentation

@beryllw beryllw marked this pull request as draft March 25, 2026 09:55
@beryllw beryllw marked this pull request as ready for review March 26, 2026 02:20
@beryllw beryllw force-pushed the tiering-fluss-read-metrics branch from 5234a72 to 81ad388 Compare March 26, 2026 03:39
@beryllw beryllw changed the title [lake/tiering] add total bytes read tracking and metrics for tiering service [lake/tiering] add bytes written tracking and metrics for tiering service Mar 26, 2026
@beryllw beryllw force-pushed the tiering-fluss-read-metrics branch from 707be6d to 88d22cb Compare March 26, 2026 07:09
Copy link
Copy Markdown
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beryllw Thanks for the pr. Left minor comments. PTAL


private final Counter writtenBytesCounter;

public TieringMetrics(SourceReaderMetricGroup sourceReaderMetricGroup) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, this metrics is reported to flink metric, right? Is it same to flink cdc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite the same. The tiering job keeps read and write in one operator (no shuffle), while Flink CDC introduces shuffle between the source and sink.

@beryllw beryllw force-pushed the tiering-fluss-read-metrics branch from f234e83 to 5c3992c Compare March 30, 2026 09:17
- Removed LakeWriter from test coverage exclusion list in pom.xml
- Deleted testTotalBytesRead method from ScanRecordsTest class
- Cleaned up redundant test cases for total bytes read functionality
- Updated test suite to align with current code coverage requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lake/tiering] add bytes written tracking and metrics for tiering service

4 participants