[server] Support max partition number of a table #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caozhen1937
force-pushed
the
max_partition_num
branch
from
1dce91a to
3478926
Compare
2 tasks
wuchong
requested changes
Mar 31, 2025
fluss-common/src/main/java/com/alibaba/fluss/exception/TooManyPartitionsException.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/MetadataManager.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/AutoPartitionManager.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/MetadataManager.java
Show resolved
Hide resolved
fluss-server/src/test/java/com/alibaba/fluss/server/coordinator/AutoPartitionManagerTest.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/zk/ZooKeeperClient.java
Show resolved
Hide resolved
…PartitionsException.java Co-authored-by: Jark Wu <[email protected]>
Contributor
Author
|
@wuchong Thank you for the review, comments addressed. |
wuchong
reviewed
Apr 1, 2025
| LOG.warn(f.getMessage()); | ||
| } | ||
|
|
||
| currentPartitions.add(partition.getPartitionName()); |
Member
There was a problem hiding this comment.
We should move this into the above try catch, otherwise, the state of currentPartitions is not correct.
wuchong
approved these changes
Apr 1, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
I pushed a commit to fix the above comment. Will merge once the CI is passed.
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #687
Brief change log
Tests
API and Format
Documentation