Skip to content

perf(rust): optimize set_bytes with direct copy_nonoverlapping #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
borngraced wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(rust): optimize set_bytes with direct copy_nonoverlapping #3102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions rust/fory-core/src/buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,17 @@ impl<'a> Writer<'a> {

#[inline(always)]
pub fn set_bytes(&mut self, offset: usize, data: &[u8]) {
self.bf
.get_mut(offset..offset + data.len())
.unwrap()
.copy_from_slice(data);
debug_assert!(offset + data.len() <= self.bf.len());
// SAFETY: Callers write placeholder bytes first (via write_*/skip), then
// call set_bytes to back-fill. The offset always points to previously
// written data within bounds.
unsafe {
std::ptr::copy_nonoverlapping(
data.as_ptr(),
self.bf.as_mut_ptr().add(offset),
data.len(),
);
}
}

#[inline(always)]
Expand Down
Loading