-
Notifications
You must be signed in to change notification settings - Fork 154
[ISSUE-369]add cluster_coefficient UDGA #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@watchMaker-sylar I have updated my understanding of the algorithm in the comments. Suggested Improvements or Alternatives:
Reduce communication volume:
In my implementation, only three iterations are needed because the process of sending/receiving messages has already sent out the neighbor list in the first iteration and received and processed these lists in the second iteration. Since the vertex stores its neighbor list in the vertex value, there is no need for an additional round to "prepare" or "distribute" this data. Therefore, it can be completed in just three steps: sending (1) → receiving and counting (2) → calculating the output (3). |
|
@kitalkuyo-gita Thanks for your reply
|
|
Regarding the second point, you can try the following usage: Sampling method (memory-saving type, you can adjust as needed): |
|
I understand what you mean. But I see this issue has already been resolved, so do I need to raise the PR again? Or how should I handle this PR? |
In my implementation, there is no sampling function to control the number of communications between nodes. If you wish, you may be able to add a sampling function based on my version. |
3790732 to
3f7b695
Compare
Your code structure is excellent, which allows me to easily add sampling functionality directly on top of your version. Can you help me check if it meets the expectations? |
I just saw your message. I've been working overtime these past few days. I'll try to review your code when I have some free time this week. |
|
No problem at all! I really appreciate you taking the time to check in, especially when you've been so busy with overtime. Please don't feel any pressure or rush. Focus on your work and your own well-being first. Whenever you get a spare moment, I'll be happy to hear your thoughts. |
Please fix CI first. |
kitalkuyo-gita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
添加了cluster_coefficient到UDGA中#369
How was this PR tested?