Skip to content

Conversation

@henri-tremblay
Copy link
Contributor

For all changes:

  • [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? GEODE-7483
  • [x ] Has your PR been rebased against the latest commit within the target branch (typically develop)? Yes
  • [ x] Is your initial contribution a single, squashed commit? Yes
  • [ x] Does gradlew build run cleanly? Yes
  • [ x] Have you written or updated unit tests to verify your changes? It's JVM dependent, so new unit tests

We probably should add GC permutations in gradle.yml.

  • [ x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? Nothing new

@JinwooHwang
Copy link
Contributor

Initiating the checks for @henri-tremblay

@JinwooHwang JinwooHwang reopened this Aug 28, 2025
@JinwooHwang JinwooHwang self-requested a review August 28, 2025 09:31
Copy link
Contributor

@JinwooHwang JinwooHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds support for identifying the "ZGC Old Generation" memory pool in the isTenured method, which enhances compatibility with generational ZGC. The update is concise, follows the existing pattern, and is clearly commented. This should help ensure accurate heap monitoring on JVMs using generational ZGC.

LGTM

  • Clear and consistent addition.
  • Improves support for more JVM configurations.
  • No impact on existing logic.

@JinwooHwang JinwooHwang merged commit 93234a5 into apache:develop Aug 28, 2025
24 of 29 checks passed
JinwooHwang pushed a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants