Skip to content

Conversation

@JinwooHwang
Copy link
Contributor

@JinwooHwang JinwooHwang commented Apr 24, 2025

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@JinwooHwang
Copy link
Contributor Author

Could you let me know what needs to be done for this to move forward? Thanks.

@semioticrobotic
Copy link
Contributor

@niallkp: As per mailing list discussion, any chance you're able to review this?

@JinwooHwang
Copy link
Contributor Author

@niallkp, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you.

@JinwooHwang
Copy link
Contributor Author

@sboorlagadda and @niallkp , Do you have any concerns regarding this PR?

@JinwooHwang
Copy link
Contributor Author

Can someone complete the checks please?

@raboof
Copy link
Member

raboof commented Aug 27, 2025

The CI tests for this PR have not ran yet, likely because you opened this before you got commit access. I'll try closing and reopening this PR to trigger them.

@raboof raboof closed this Aug 27, 2025
@raboof raboof reopened this Aug 27, 2025
@JinwooHwang
Copy link
Contributor Author

Thank you very much for starting the checks, @raboof.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the main branch is green after #7916 I'm confident any regressions caused by the update will be noticed, so this LGTM.

@raboof raboof merged commit 7cc1fbb into apache:develop Aug 28, 2025
15 of 17 checks passed
JinwooHwang added a commit that referenced this pull request Sep 3, 2025
(cherry picked from commit 7cc1fbb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants