-
Notifications
You must be signed in to change notification settings - Fork 695
Apache Shiro Upgrade to 1.13.0 #7898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sboorlagadda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JinwooHwang-SAS Approving this as its version upgrade.
|
Would you please let me know what needs to be done for this to move forward? Thanks. |
|
@niallkp: As per mailing list discussion, any chance you're able to review this? |
|
Hi @JinwooHwang-SAS , looks like some failing required checks. Can you verify/rerun them? |
|
Hi @scmbuildguy , Could you please help me understand the error, Error: Cache service responded with 422? I don't see any issues with the changes that I have made. Thanks. |
|
@niallkp and @scmbuildguy, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you. |
|
closing/reopening to re-run the checks since the logs have been garbage-collected |
|
Thank you very much @raboof . The checks are starting. |
raboof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the main branch is green after #7916 I'm confident any regressions caused by the update will be noticed, so this LGTM.
(cherry picked from commit dbbc91f)
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?