-
Notifications
You must be signed in to change notification settings - Fork 695
commons-beanutil 1.11.0 #7904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commons-beanutil 1.11.0 #7904
Conversation
|
The CI tests for this PR have not ran yet, likely because you opened this before you got commit access. I'll try closing and reopening this PR to trigger them. |
raboof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK if CI is green
|
Thank you very much @raboof |
|
the integration test fails: I think it would be good to delay merging this PR until the integration tests are green. I'd be OK with fixing the commons-logging reference here or in a separate PR. (I think I merged #7903 to hastily, sorry about that) |
|
Thank you for pointing this out and for the thoughtful suggestion, @raboof. You’re absolutely right — we should hold off on merging until the integration tests are fully green. I apologize for the mismatch with the commons-logging versions. I’ve addressed the issue in PR #7918 , and I’ll re-run the checks to see if it passes this time. And no worries at all about #7903 — I truly appreciate your quick reviews, guidance, and support throughout this process. |
|
@raboof, all checks have now passed. Please let me know if you have any further concerns or suggestions. Thank you. |
|
Thank you @raboof for merging the commit. |
* commons-beanutil 1.11.0 * commons-beanutil 1.11.0 (cherry picked from commit ca5d830)
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?