Skip to content

Conversation

@JinwooHwang
Copy link
Contributor

@JinwooHwang JinwooHwang commented Jul 1, 2025

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@JinwooHwang JinwooHwang requested a review from raboof August 27, 2025 09:58
@raboof
Copy link
Member

raboof commented Aug 27, 2025

The CI tests for this PR have not ran yet, likely because you opened this before you got commit access. I'll try closing and reopening this PR to trigger them.

@raboof raboof closed this Aug 27, 2025
@raboof raboof reopened this Aug 27, 2025
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if CI is green

@JinwooHwang
Copy link
Contributor Author

Thank you very much @raboof

@raboof
Copy link
Member

raboof commented Aug 29, 2025

the integration test fails:

    elements not found:
      ["commons-logging-1.2.jar"]
    and elements not expected:
      ["commons-logging-1.3.5.jar"]

I think it would be good to delay merging this PR until the integration tests are green. I'd be OK with fixing the commons-logging reference here or in a separate PR. (I think I merged #7903 to hastily, sorry about that)

@JinwooHwang
Copy link
Contributor Author

Thank you for pointing this out and for the thoughtful suggestion, @raboof. You’re absolutely right — we should hold off on merging until the integration tests are fully green. I apologize for the mismatch with the commons-logging versions. I’ve addressed the issue in PR #7918 , and I’ll re-run the checks to see if it passes this time. And no worries at all about #7903 — I truly appreciate your quick reviews, guidance, and support throughout this process.

@JinwooHwang
Copy link
Contributor Author

JinwooHwang commented Aug 29, 2025

@raboof, all checks have now passed. Please let me know if you have any further concerns or suggestions. Thank you.

@raboof raboof merged commit ca5d830 into apache:develop Aug 30, 2025
17 checks passed
@JinwooHwang
Copy link
Contributor Author

Thank you @raboof for merging the commit.

JinwooHwang added a commit that referenced this pull request Sep 3, 2025
* commons-beanutil 1.11.0

* commons-beanutil 1.11.0

(cherry picked from commit ca5d830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants