SizeClassOnceObjectSizerJUnitTest #7906
Conversation
| ObjectSizer.SIZE_CLASS_ONCE.sizeof(s1)); | ||
| assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 10 * 2), | ||
| ObjectSizer.SIZE_CLASS_ONCE.sizeof(s2)); | ||
| if (SystemUtils.isAzulJVM()) { |
There was a problem hiding this comment.
Like in the other PR, let's guard the Azul behavior we don't quite understand yet in if (!SystemUtils.isAzulJVM()) {
There was a problem hiding this comment.
Thank you very much for your review, @raboof. Are you comfortable proceeding with the merge at this point?
There was a problem hiding this comment.
I would prefer wrapping the asserts in a if (!SystemUtils.isAzulJVM()) { block instead of adding asserts with + 8, just like in #7907
There was a problem hiding this comment.
Thank you for your guidance, @raboof. I've incorporated your suggestion into the latest update. Would you be willing to review the commit when you have a moment?
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
LGTM. Doesn't need to be 3 commits but we can 'Squash and merge' after CI confirms there's no unexpected failures.
|
Thank you so much for your approval, @raboof. |
* SizeClassOnceObjectSizerJUnitTest (cherry picked from commit 686d519)
2 participants
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?