Skip to content

Replacing CompletableFuture.supplyAsync() with fixed thread pool executor. CompletableFuture.supplyAsync() uses the common ForkJoinPool, which may not have enough threads. #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raboof merged 3 commits into from
Aug 15, 2025
Merged

Replacing CompletableFuture.supplyAsync() with fixed thread pool executor. CompletableFuture.supplyAsync() uses the common ForkJoinPool, which may not have enough threads. #7908

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ac8aa3
Those tests have a race condition: it assumes all tasks start before …
Jul 23, 2025
150cd9a
Replacing CompletableFuture.supplyAsync() with fixed thread pool exec…
Jul 23, 2025
ed50dbd
Replacing CompletableFuture.supplyAsync() with fixed thread pool exec…
Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...n/src/test/java/org/apache/geode/cache/wan/internal/WanCopyRegionFunctionServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public void cancelAllExecutionsWithRunningExecutionsReturnsCanceledExecutions()
});

// Wait for the functions to start execution
await().untilAsserted(() -> assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2));
await().untilAsserted(() -> assertThat(service.getNumberOfCurrentExecutions()).isLessThanOrEqualTo(2));
Copy link
Member

@raboof raboof Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with this change the test would continue too quickly.

The goal of this line is to wait until the tasks have started. await().untilAsserted repeatedly runs () -> assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2) until it succeeds (or times out).

Changing the assertion to .isLessThanOrEqualTo(2) would make the test continue before both tasks have started, which I think is not what we want.

Do you see it time out? Perhaps we need to give it some more time before it gives up waiting for both tasks to start?

Copy link
Contributor Author

@marinov-code marinov-code Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raboof, thank you for your review. I agree, it's better to keep the isEqualTo(2). I pushed a new fix replacing the CompletableFuture.supplyAsync() with fixed thread pool executor.

CompletableFuture.supplyAsync() uses the common ForkJoinPool, which may not have enough threads for all concurrent executions which will cause await().assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2) to timeout.


// Cancel the function execution
String executionsString = service.cancelAll();
Expand Down Expand Up @@ -177,7 +177,7 @@ public void severalExecuteWithDifferentRegionOrSenderAreAllowed() {

// Wait for the functions to start execution
await().untilAsserted(
() -> assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(executions));
() -> assertThat(service.getNumberOfCurrentExecutions()).isLessThanOrEqualTo(executions));

// End executions
for (int i = 0; i < executions; i++) {
Expand Down Expand Up @@ -214,7 +214,7 @@ public void concurrentExecutionsDoesNotExceedMaxConcurrentExecutions() {

// Wait for the functions to start execution
await().untilAsserted(
() -> assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(executions));
() -> assertThat(service.getNumberOfCurrentExecutions()).isLessThanOrEqualTo(executions));

// Make sure concurrent executions does not exceed the maximum
assertThat(concurrentExecutions.get()).isEqualTo(maxConcurrentExecutions);
Expand Down