-
Notifications
You must be signed in to change notification settings - Fork 695
Update NullLogWriter to migrate NullOutputStream to INSTANCE #7909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It would be good to mention the motivation for the change in the PR. In this case indeed |
OK looks like the motivation is just "I wanted to update commons-io and had to fix this deprecation error" - simple, but still would be worth mentioning :) |
|
Yes, that’s exactly it, @raboof. I just wanted to update commons-io and needed to address the deprecation error along the way. Thank you for pointing out that it’s worth mentioning — I really appreciate the reminder, I’ll be sure to note it more clearly next time. |
raboof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the main branch is green after #7916 I'm confident any regressions caused by the update will be noticed, so this LGTM.
|
@JinwooHwang-SAS this caused a failure of the integration tests in https://github.com/apache/geode/actions/runs/17291015222/job/49079826921 - looks like the version update needs to be registered somewhere else as well? Could you follow up? |
|
cool - is that commit in a PR somewhere yet? (also the comment seems to mention beanutils instead of io) |
|
@raboof . Yes, I made the update while working on PR #7904. In hindsight, it would have been much clearer to include it in PR #7902, and I sincerely apologize for that oversight. Thank you very much for catching this and for your patience — I truly appreciate your guidance and support throughout the review. |
(cherry picked from commit 8e0fdc2)
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?