Skip to content

Conversation

@marinov-code
Copy link
Contributor

…st > testSerializables fails on CI

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@JinwooHwang
Copy link
Contributor

Approved the build request.

@JinwooHwang
Copy link
Contributor

@marinov-code , Could you please take a look at the failed tests? Thanks in advance.

@raboof
Copy link
Member

raboof commented Aug 26, 2025

If you click the failed integrationTest GitHub Actions job, you can see that AnalyzeCoreSerializablesIntegrationTest is still failing:


AnalyzeCoreSerializablesIntegrationTest > testSerializables FAILED
    java.lang.AssertionError: New or moved classes----------------------------------------
    org/apache/geode/management/internal/json/AbstractJSONFormatter$PreventReserializationModule$1,false,this$0:org/apache/geode/management/internal/json/AbstractJSONFormatter$PreventReserializationModule
    org/apache/geode/management/internal/json/QueryResultFormatter$TypeSerializationEnforcerModule$1,false,this$0:org/apache/geode/management/internal/json/QueryResultFormatter$TypeSerializationEnforcerModule

    If the class is not persisted or sent over the wire, add it to the file
        /home/runner/work/geode/geode/geode-core/src/integrationTest/resources/org/apache/geode/codeAnalysis/excludedClasses.txt
    Otherwise, if this doesn't break backward compatibility, copy the file
        /home/runner/work/geode/geode/geode-core/build/integrationTest/test-worker-001022/actualSerializables.dat
        to 
        /home/runner/work/geode/geode/geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt
    If this potentially breaks backward compatibility, follow the instructions in
        geode-serialization/ANALYZE_SERIALIZABLES.md

@raboof
Copy link
Member

raboof commented Aug 27, 2025

It seems AnalyzeCoreSerializablesIntegrationTest > testSerializables was fixed in #7915 - was this PR intended to fix a different issue?

@raboof
Copy link
Member

raboof commented Aug 27, 2025

ah isn't this change already in #7914?

@JinwooHwang JinwooHwang self-requested a review August 27, 2025 20:41
@JinwooHwang
Copy link
Contributor

Closing this since this problem has been addressed by 9d736a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants