-
Notifications
You must be signed in to change notification settings - Fork 695
GEODE-10459: Fix for docker compose using shim #7917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
raboof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if #7916 works I would prefer that, but if not then this seems like a reasonable alternative until we can upgrade testcontainers.
|
(that |
|
This does seem problematic though: |
|
Yeah those seem problematic. Maybe its a incompatibility with the docker v2 compose? I could try ensuring that is used instead but that's probably not recommended. Going to read more into what is going on now since it may be a step forward |
|
This seems irrelevant now, so I will close this as it was the wrong approach. #7916 is the better option |
This attempts to fix the acceptance test docker-compose issue by adding a shim to make a call to
docker-compose(docker compose v1) and make it usedocker compose(space included) docker compose v2 version.For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?