Skip to content

Conversation

@JinwooHwang
Copy link
Contributor

Summary

  • Updates only the recorded dependency snapshot resource files to reflect current resolved versions of commons-logging (1.3.5) and snappy (0.5):
  • gfsh_dependency_classpath.txt
  • dependency_classpath.txt

Rationale

  • These files are used by integration / classpath verification tests. The build already resolves commons-logging-1.3.5.jar and snappy-0.5.jar; snapshots were stale and caused (or could cause) false negatives when asserting expected runtime artifacts. This PR aligns the snapshot expectations with the actual dependency graph without altering any Gradle build logic or constraints.

Scope of Change

  • Replaced old commons-logging line with: commons-logging-1.3.5.jar
  • Replaced old snappy line with: snappy-0.5.jar
  • No other ordering or entries modified.

Out of Scope

  • No edits to build scripts, dependency constraints, BOMs, exclusions, or published artifacts.
  • No code changes in compression or logging subsystems.

Risk Minimal

  • passive test resource update; does not affect runtime packaging or published artifacts.

Validation

  1. Ran ./gradlew build (success).
  2. Confirmed the two updated jar names exist in assembled distribution lib/ and on the resolved test classpath.
  3. Ensured no duplicate older versions remain (grep for commons-logging-1.* / snappy-0.* in classpath output).

Reviewer Notes

  • Diff should show only two single-line substitutions (one per artifact per file). Verify no whitespace noise.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@JinwooHwang JinwooHwang requested a review from raboof August 28, 2025 14:08
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's merge when CI is green

@JinwooHwang
Copy link
Contributor Author

Thank you very much @raboof

@JinwooHwang
Copy link
Contributor Author

Thank you very much @raboof . All checks have passed.

@JinwooHwang JinwooHwang merged commit 6d128a0 into apache:develop Aug 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants