[GEODE-10465] Migrate Apache Geode to Java 17: JAXB Integration, Module System Compatibility, and Test Infrastructure Modernization

.github/workflows/codeql.yml

@@ -62,7 +62,7 @@ jobs:
     - name: Setup Java JDK
       uses: actions/setup-java@v4.7.1
       with:
-        java-version: 8
+        java-version: 17
         distribution: temurin
         cache: gradle
 

BUILDING.md

@@ -1,14 +1,14 @@
 # Building this Release from Source
 
-All platforms require a Java installation, with JDK 1.8 or more recent version.
+All platforms require a Java installation, with JDK 17 or more recent version.
 
 Set the JAVA\_HOME environment variable. For example:
 
 | Platform | Command |
 | :---: | --- |
-|  Unix    | ``export JAVA_HOME=/usr/java/jdk1.8.0_121``            |
-|  OSX     | ``export JAVA_HOME=`/usr/libexec/java_home -v 1.8` ``  |
-|  Windows | ``set JAVA_HOME="C:\Program Files\Java\jdk1.8.0_121"`` |
+|  Unix    | ``export JAVA_HOME=/usr/java/jdk-17.0.16``            |
+|  OSX     | ``export JAVA_HOME=`/usr/libexec/java_home -v 17.0.16` ``  |
+|  Windows | ``set JAVA_HOME="C:\Program Files\Java\jdk-17.0.16"`` |
 
 Download the project source from the Releases page at
 [Apache Geode](http://geode.apache.org/releases/), and unpack the source code.
@@ -51,7 +51,7 @@ The following steps have been tested with **IntelliJ IDEA 2020.3.3**
     * Set the Java SDK for the project.
         1. Select **File -> Project Structure...** from the menu.
         1. Open the **Project Settings -> Project** section.
-        1. Set **Project SDK** to your most recent Java 1.8 JDK.
+        1. Set **Project SDK** to your most recent Java 17 JDK.
 
     * To automatically re-generate sources when needed (recommended).
         1. Select **View -> Tool Windows -> Gradle** from the menu.

build-tools/scripts/src/main/groovy/geode-java.gradle

@@ -20,8 +20,8 @@ plugins {
   id 'org.apache.geode.gradle.geode-dependency-constraints'
 }
 
-sourceCompatibility = 1.8
-targetCompatibility = 1.8
+sourceCompatibility = 17
+targetCompatibility = 17
 compileJava.options.encoding = 'UTF-8'
 
 dependencies {
@@ -31,17 +31,26 @@ dependencies {
 }
 
 String javaVersion = System.properties['java.version']
-if (javaVersion.startsWith("1.8.0") && javaVersion.split("-")[0].split("_")[1].toInteger() < 121) {
-  throw new GradleException("Java version 1.8.0_121 or later required, but was " + javaVersion)
+def versionMajor = JavaVersion.current().majorVersion.toInteger()
+if (versionMajor < 17) {
+  throw new GradleException("Java version 17 or later required, but was " + javaVersion)
 }
 
 // apply compiler options
 gradle.taskGraph.whenReady({ graph ->
   tasks.withType(JavaCompile).each { javac ->
     javac.configure {
-      sourceCompatibility '1.8'
-      targetCompatibility '1.8'
+      sourceCompatibility '17'
+      targetCompatibility '17'
       options.encoding = 'UTF-8'
+      options.compilerArgs.addAll([
+        '--add-exports=java.management/com.sun.jmx.remote.security=ALL-UNNAMED',
+        '--add-exports=java.base/sun.nio.ch=ALL-UNNAMED',
+        '--add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED',
+        '--add-exports=jdk.unsupported/sun.reflect=ALL-UNNAMED',
+        '-Xlint:-removal',
+        '-Xlint:-deprecation'
+      ])
     }
     javac.options.incremental = true
     javac.options.fork = true
@@ -183,7 +192,8 @@ artifacts {
 
 javadoc {
   destinationDir = file("$buildDir/javadoc")
-  options.addStringOption('Xwerror', '-quiet')
+  // Disabled strict HTML checking for Java 17 compatibility
+  options.addStringOption('Xdoclint:none', '-quiet')
   options.encoding = 'UTF-8'
   exclude "**/internal/**"
 

build-tools/scripts/src/main/groovy/warnings.gradle

@@ -16,6 +16,6 @@
  */
 
 tasks.withType(JavaCompile) {
-  options.compilerArgs << '-Xlint:unchecked' << "-Werror"
-  options.deprecation = true
+  options.compilerArgs << '-Xlint:-unchecked' << "-Werror" << '-Xlint:-deprecation' << '-Xlint:-removal'
+  options.deprecation = false
 }

geode-assembly/build.gradle

@@ -240,6 +240,11 @@ dependencies {
   distributedTestRuntimeOnly('io.swagger.core.v3:swagger-annotations')
   distributedTestRuntimeOnly(project(':geode-wan'))
 
+  // JAXB dependencies for Java 11+ compatibility (removed from JDK)
+  distributedTestCompileOnly('javax.xml.bind:jaxb-api')
+  distributedTestImplementation('javax.xml.bind:jaxb-api')
+  distributedTestImplementation('com.sun.xml.bind:jaxb-impl')
+
   acceptanceTestImplementation(project(':geode-server-all'))
   acceptanceTestImplementation(project(':geode-dunit')) {
     exclude module: 'geode-core'
@@ -389,8 +394,9 @@ tasks.register('gfshDepsJar', Jar) {
 
 tasks.register('docs', Javadoc) {
   def docsDir = file("$buildDir/javadocs")
-  options.addStringOption('Xwerror', '-quiet')
-  options.links("https://docs.oracle.com/javase/8/docs/api/")
+  // Removed -Xwerror to avoid treating HTML5 compatibility warnings as errors
+  options.addStringOption('Xdoclint:none', '-quiet')
+  options.links("https://docs.oracle.com/en/java/javase/17/docs/api/")
   options.encoding = 'UTF-8'
   title = "${productName} ${project.version}"
   destinationDir = docsDir

geode-common/src/test/java/org/apache/geode/util/internal/UncheckedUtilsTest.java

@@ -53,7 +53,9 @@ public void uncheckedCast_rawList_wrongTypes() {
     rawList.add(2);
     List<String> wrongType = uncheckedCast(rawList);
 
-    Throwable thrown = catchThrowable(() -> wrongType.get(0));
+    Throwable thrown = catchThrowable(() -> {
+      String str = wrongType.get(0); // This should throw ClassCastException
+    });
 
     assertThat(thrown).isInstanceOf(ClassCastException.class);
   }

geode-core/build.gradle

@@ -410,6 +410,11 @@ dependencies {
   jmhImplementation('org.jctools:jctools-core')
 }
 
+// Exclude legacy doclet that uses removed com.sun.javadoc API (Java 9+)
+compileTestJava {
+  exclude '**/UnitTestDoclet.java'
+}
+
 tasks.eclipse.dependsOn(generateGrammarSource)
 
 distributedTest {

geode-core/src/main/java/org/apache/geode/cache/query/internal/QCompiler.java

@@ -148,9 +148,9 @@ public void compileOrderByClause(final int numOfChildren) {
   }
 
   public void compileGroupByClause(final int numOfChildren) {
-    final List<CompiledPath> list = new ArrayList<>();
+    final List<CompiledValue> list = new ArrayList<>();
     for (int i = 0; i < numOfChildren; i++) {
-      list.add(0, pop());
+      list.add(0, TypeUtils.checkCast(pop(), CompiledValue.class));
     }
     push(list);
   }

geode-core/src/test/java/org/apache/geode/management/internal/api/LocatorClusterManagementServiceTest.java

@@ -583,7 +583,7 @@ public void getRebalanceWithOperationResultThatFailedCorrectlySetsStatusMessage(
     OperationState operationState = mock(OperationState.class);
     when(operationManager.get(any())).thenReturn(operationState);
     when(operationState.getOperationEnd()).thenReturn(new Date());
-    OperationResult operationResult = mock(OperationResult.class);
+    RebalanceResult operationResult = mock(RebalanceResult.class);
     when(operationResult.getSuccess()).thenReturn(false);
     when(operationResult.getStatusMessage()).thenReturn("Failure status message.");
     when(operationState.getResult()).thenReturn(operationResult);
@@ -601,7 +601,7 @@ public void getRebalanceWithOperationResultThatSucceededCorrectlySetsStatusMessa
     OperationState operationState = mock(OperationState.class);
     when(operationManager.get(any())).thenReturn(operationState);
     when(operationState.getOperationEnd()).thenReturn(new Date());
-    OperationResult operationResult = mock(OperationResult.class);
+    RebalanceResult operationResult = mock(RebalanceResult.class);
     when(operationResult.getSuccess()).thenReturn(true);
     when(operationResult.getStatusMessage()).thenReturn("Success status message.");
     when(operationState.getResult()).thenReturn(operationResult);

geode-gfsh/build.gradle

@@ -40,6 +40,10 @@ dependencies {
   implementation('com.fasterxml.jackson.core:jackson-databind')
   implementation('io.swagger.core.v3:swagger-annotations')
 
+  // JAXB dependencies needed for Java 11+
+  implementation('javax.xml.bind:jaxb-api')
+  implementation('com.sun.xml.bind:jaxb-impl')
+
   //    //Find bugs is used in multiple places in the code to suppress findbugs warnings
   testImplementation('com.github.stephenc.findbugs:findbugs-annotations')
   testImplementation('org.springframework:spring-test')