-
Notifications
You must be signed in to change notification settings - Fork 695
Update Dockerfile for 1.15.2 #7931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile for 1.15.2 #7931
Conversation
With this change the Docker image builds, but I haven't tried running it yet.
JinwooHwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raboof, could you help me understand why 1A3694A1448840FC3B1137B2CAE347D5AE2E5C93 was replaced with 62F7DA41B7D8F26C? The new value seems significantly shorter, and I’d like to understand the reasoning or context behind the change.
|
The reason for the change is that 1.15.1 was signed by http://keyserver.ubuntu.com:11371/pks/lookup?search=1A3694A1448840FC3B1137B2CAE347D5AE2E5C93&fingerprint=on&op=index and 1.15.2 was signed by you, http://keyserver.ubuntu.com:11371/pks/lookup?search=62F7DA41B7D8F26C&fingerprint=on&op=index I'm not sure where the change in length comes from, I guess it's different formattings of the key IDs. |
JinwooHwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification, @raboof. I noticed that the key 62F7DA41B7D8F26C isn’t listed in https://github.com/apache/geode/blob/develop/KEYS. @niallkp, is this omission expected, or might I be overlooking something? Your insight would be greatly appreciated.
|
There was some discussion on the lists about this, https://lists.apache.org/thread/roo6gkgypjnp51g3rtvn4thvmbjl2bfs - I think whether to have the KEYS file in version control as well was also discussed somewhere, but I can't find a reference right now |
Ah that was in #7919 |
That's right, @raboof. It seems we haven’t yet heard from @CalvinKirs on that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, @raboof . As long as 62F7DA41B7D8F26C functions as expected, we're in good shape. We can address its absence from the KEYS file in a separate ticket or PR. Thank you so much for taking care of this issue.
|
Hi @raboof . when you have a moment, could you please confirm whether it ran successfully? |
^ it starts, but I haven't used it beyond that yet |
|
Thank you so much, @raboof . |
I have checked the build succeeds. Running the image produces:
That looks OK to my untrained eye.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?