[GLUTEN-11027] Use clang-tidy to check cpp files#11028
Closed
xinghuayu007 wants to merge 4 commits intoapache:mainfrom
Closed
[GLUTEN-11027] Use clang-tidy to check cpp files#11028xinghuayu007 wants to merge 4 commits intoapache:mainfrom
xinghuayu007 wants to merge 4 commits intoapache:mainfrom
Conversation
xinghuayu007
force-pushed
the
my/clang_tidy
branch
2 times, most recently
from
4c2d55a to
a4ce11a
Compare
xinghuayu007
force-pushed
the
my/clang_tidy
branch
from
a4ce11a to
c40ae7a
Compare
Member
|
Assume with this script, the portal to trigger the check is here: https://github.com/apache/incubator-gluten/blob/056d0e32034c367764d58a514a73fc9126b78862/dev/check.py#L170 The installation for clang-tidy seems necessary. In addition, if running the entire check requires too much time, we need to let it only check the CPP files changed by a PR. |
xinghuayu007
force-pushed
the
my/clang_tidy
branch
14 times, most recently
from
fa48589 to
b40ed14
Compare
xinghuayu007
force-pushed
the
my/clang_tidy
branch
from
b40ed14 to
fce6f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Use clang-tidy to check cpp files to make code robot.
How was this patch tested?
Related issue: #11027