[GLUTEN-1433] [VL] Add validation tests for CurrentTimestamp and now(foldable)#11656
Open
Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-1433] [VL] Add validation tests for CurrentTimestamp and now(foldable)#11656Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Conversation
Mariamalmesfer
changed the title
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
2 times, most recently
from
d50e294 to
7401292
Compare
Mariamalmesfer
changed the title
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
3 times, most recently
from
a6b9d73 to
0029a43
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
5 times, most recently
from
983aacb to
ae8d6e3
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
2 times, most recently
from
74fd232 to
fd6625d
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
from
fd6625d to
0e24929
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
from
0e24929 to
3f867f2
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
from
3f867f2 to
d8dfc8e
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
from
d8dfc8e to
8394158
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
3 times, most recently
from
129bb79 to
72731c0
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
20 times, most recently
from
5acf967 to
6b55a95
Compare
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
from
6b55a95 to
c7bcddc
Compare
Mariamalmesfer
changed the title
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
2 times, most recently
from
d0a9fb0 to
498dfa3
Compare
zhouyuan
approved these changes
Mar 13, 2026
Mariamalmesfer
force-pushed
the
validate-currenttimestamp
branch
from
498dfa3 to
2f8ee40
Compare
rui-mo
reviewed
Mar 16, 2026
| val optimizedPlan = df.queryExecution.optimizedPlan.toString() | ||
| assert( | ||
| !optimizedPlan.contains("CurrentTimestamp"), | ||
| s"Expected CurrentTimestamp to be folded to a literal, but got: $optimizedPlan" |
Contributor
There was a problem hiding this comment.
Excluding the org.apache.spark.sql.catalyst.optimizer.ConstantFolding rule via configuring spark.sql.optimizer.excludedRules might could help verify whether this function can be offloaded to native computing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation tests for
CurrentTimestampandnowas part of #1433.CurrentTimestampandnowis a foldable expression and is computed by Spark during query planning.The added tests verify that:
This confirms that
CurrentTimestampandnowis supported on the Velox backend.Closes part of #1433