Skip to content

Commit 1320461

Browse files
committed
address review comments
1 parent cd1e492 commit 1320461

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/service/ManagedWorkflowServiceStubs.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,16 @@ public ManagedWorkflowServiceStubs(WorkflowServiceStubs serviceStubs) {
3939
@Override
4040
public void close() {
4141
try {
42-
try {
43-
workflowServiceStubs.getOptions().getMetricsScope().close();
44-
}
45-
finally {
46-
workflowServiceStubs.shutdown();
47-
}
42+
workflowServiceStubs.getOptions().getMetricsScope().close();
4843
}
4944
catch (Exception e) {
50-
log.error("Exception occurred while closing ManagedWorkflowServiceStubs", e);
45+
log.error("Exception occurred while closing metrics scope", e);
46+
}
47+
try {
48+
workflowServiceStubs.shutdown();
49+
}
50+
catch (Exception e) {
51+
log.error("Exception occurred while shutting down WorkflowServiceStubs", e);
5152
}
5253
}
5354
}

0 commit comments

Comments
 (0)