Skip to content

[GOBBLIN-2182] Cleanup workdir in Gobblin-on-Temporal execution #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishekmjain merged 2 commits into from
Jan 20, 2025
Merged

[GOBBLIN-2182] Cleanup workdir in Gobblin-on-Temporal execution #4085

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3510fa8
added cleanup for got controlled with a config
Blazer-007 Dec 12, 2024
8a762f9
addressed comments
Blazer-007 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public interface GobblinTemporalConfigurationKeys {

String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX = GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_CONFIG_OVERRIDES = GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "config.overrides";
String GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = PREFIX + "clean.up.work.dir";
String DEFAULT_GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = "true";

/**
* Suffix for metrics emitted by GobblinTemporalJobLauncher for preventing collisions with prod jobs
Expand Down
15 changes: 14 additions & 1 deletion ...in-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
import org.apache.gobblin.source.workunit.WorkUnit;
import org.apache.gobblin.util.ConfigUtils;
import org.apache.gobblin.util.ParallelRunner;
import org.apache.gobblin.temporal.ddm.util.JobStateUtils;
import org.apache.gobblin.temporal.GobblinTemporalConfigurationKeys;

/**
* An implementation of {@link JobLauncher} that launches a Gobblin job using the Temporal task framework.
Expand Down Expand Up @@ -134,7 +136,11 @@ public void close() throws IOException {
try {
executeCancellation();
} finally {
super.close();
try {
cleanupWorkingDirectory();
} finally {
super.close();
}
}
}

Expand Down Expand Up @@ -277,6 +283,13 @@ protected void cleanupWorkingDirectory() throws IOException {
GobblinClusterUtils.getJobStateFilePath(false, this.appWorkDir, this.jobContext.getJobId());
this.fs.delete(jobStateFilePath, false);
}

if (Boolean.parseBoolean(this.jobProps.getProperty(GobblinTemporalConfigurationKeys.GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR,
GobblinTemporalConfigurationKeys.DEFAULT_GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR))) {
Path workDirRootPath = JobStateUtils.getWorkDirRoot(this.jobContext.getJobState());
log.info("Cleaning up work directory : {} for job : {}", workDirRootPath, this.jobContext.getJobId());
this.fs.delete(workDirRootPath, true);
}
}
}