[GOBBLIN-2187] Fix NaN issue while generating size summary#4090
Merged
phet merged 2 commits intoapache:masterfrom Jan 6, 2025
Merged
[GOBBLIN-2187] Fix NaN issue while generating size summary#4090phet merged 2 commits intoapache:masterfrom
phet merged 2 commits intoapache:masterfrom
Conversation
phet
approved these changes
Jan 6, 2025
Contributor
phet
left a comment
There was a problem hiding this comment.
nice work - thank you vivek!
...poral/src/main/java/org/apache/gobblin/temporal/ddm/activity/impl/GenerateWorkUnitsImpl.java
Show resolved
Hide resolved
...l/src/test/java/org/apache/gobblin/temporal/ddm/activity/impl/GenerateWorkUnitsImplTest.java
Outdated
Show resolved
Hide resolved
phet
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
when
workunitis empty then while serializing wusizesummary GSON throws below exceptionNaN is not a valid double value as per JSON specification. To override this behavior, use GsonBuilder.serializeSpecialFloatingPointValues() methodthis is coming due to not handling when values are zeros which generates NaN while generating wusizesummary
Tests
added
testDigestWorkUnitsSizeWithEmptyWorkUnitsCommits