Restructure grails-cache so that plugin, examples, and docs are separate #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
doc generation now works correctly in the subproject. @matrei I moved the groovydoc generation into the subproject. I think we can use this project structure as a best practice "example" plugin application now too. |
jamesfredley
approved these changes
Feb 10, 2025
Contributor
Author
|
@matrei I only added you to the review here in case you wanted to look at how I did the groovy doc. I'm going to go ahead and merge this since @jamesfredley approved. Let me know if you disagree or can find an alternative approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the grails-cache plugin so it doesn't export everything as an api dependency. I've also split out the project into docs, example, and plugin so plugin specific code can be shipped separately from examples.
There's likely still an issue with doc generation that will need to be troubleshooted. It's related to apache/grails-core#13984 upgrading from 4.0.24 to 4.0.25, but not recompiling all of the grails projects (so there are mismatching versions of groovy)