Skip to content

Commit 7f9a2c0

Browse files
committed
Update RELEASE.md with improved container instructions
Added platform-specific Docker commands for macOS/Linux and Windows to the verification section. Updated reference to the appendix with a markdown link for better navigation.
1 parent ee99807 commit 7f9a2c0

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

RELEASE.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ For Example:
8383
Please note that this script will perform steps that will require rebuilding the project & comparing the built artifacts
8484
to the staged artifacts. Due to OS differences, this can result in reproducibility issues. For this reason, it's advised
8585
to run these scripts from an environment similar to the GitHub actions environment. See the section
86-
`Appendix: Verification from a Container` for how to launch a container that closely resembles the GitHub actions
86+
[Appendix: Verification from a Container](RELEASE.md#appendix-verification-from-a-container) for how to launch a container that closely resembles the GitHub actions
8787
environment.
8888

8989
If manual verification is desired, the steps below can be followed.
@@ -385,12 +385,20 @@ Setup the key for validity:
385385
The Grails image is officially built on linux in a GitHub action using an Ubuntu container. To run a linux container
386386
locally, you can use the following command (substitute `<git-tag-of-release` with the tag name):
387387

388+
**macOS/Linux**
388389
```bash
389390
docker build -t grails:testing -f etc/bin/Dockerfile . && docker run -it --rm -v $(pwd):/home/groovy/project -p 8080:8080 grails:testing bash
390391
cd grails-verify
391392
verify.sh <git-tag-of-release> .
392393
```
393394

395+
**Windows**
396+
```bash
397+
docker build -t grails:testing -f etc/bin/Dockerfile . && docker run -it --rm -v "%CD%:/home/groovy/project" -p 8080:8080 grails:testing bash
398+
cd grails-verify
399+
verify.sh <git-tag-of-release> .
400+
```
401+
394402
Please note that the argument `-p 8080:8080` is used to expose the port 8080 of the container to the host machine's port 8080 (fromContainerPort:toHostPort). This allows you to access any running Grails application in the container from your host. If you have another application on port 8080, you can change the port mapping to avoid conflicts, e.g., `-p 8080:8081`.
395403
396404
In the event that artifacts differ, simply copy them to your project directory and work on your local machine instead of the docker image:

0 commit comments

Comments
 (0)