Skip to content

Commit a7f00c7

Browse files
committed
Revert "feat(core): Remove/Replace deprecated Groovy classes to prepare upgrade to Groovy 4 (#13386)"
This reverts commit e2061a8. # Conflicts: # gradle.properties # grails-databinding/src/test/groovy/grails/databinding/SimpleDataBinderSpec.groovy
1 parent d001c6c commit a7f00c7

File tree

72 files changed

+478
-566
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+478
-566
lines changed

gradle/idea.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import groovy.xml.XmlParser
2-
31
idea {
42
project {
53
jdkName "1.7"

grails-bootstrap/src/main/groovy/grails/codegen/model/ModelBuilder.groovy

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ package grails.codegen.model
1717

1818
import grails.util.GrailsNameUtils
1919
import groovy.transform.CompileStatic
20-
import org.apache.groovy.util.BeanUtils
20+
import org.codehaus.groovy.runtime.MetaClassHelper
2121
import org.grails.io.support.FileSystemResource
2222
import org.grails.io.support.GrailsResourceUtils
2323
import org.grails.io.support.Resource
@@ -89,7 +89,7 @@ trait ModelBuilder {
8989
final String packagePath
9090

9191
ModelImpl(String className) {
92-
this.className = BeanUtils.capitalize(GrailsNameUtils.getShortName(className))
92+
this.className = MetaClassHelper.capitalize(GrailsNameUtils.getShortName(className))
9393
this.fullName = className
9494
this.propertyName = GrailsNameUtils.getPropertyName(className)
9595
this.packageName = GrailsNameUtils.getPackageName(className)
@@ -111,14 +111,7 @@ trait ModelBuilder {
111111

112112
@Override
113113
Map<String, Object> asMap() {
114-
[className: className,
115-
fullName: fullName,
116-
propertyName: propertyName,
117-
modelName: propertyName,
118-
packageName: packageName,
119-
packagePath: packagePath,
120-
simpleName: simpleName,
121-
lowerCaseName: lowerCaseName] as Map<String, Object>
114+
(Map<String,Object>) [ className: className, fullName: fullName, propertyName: propertyName, modelName: propertyName, packageName: packageName, packagePath: packagePath, simpleName: simpleName, lowerCaseName: lowerCaseName]
122115
}
123116
}
124117

grails-bootstrap/src/main/groovy/org/grails/io/support/SpringIOUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.grails.io.support;
1717

18-
import groovy.xml.XmlSlurper;
18+
import groovy.util.XmlSlurper;
1919
import groovy.xml.FactorySupport;
2020
import org.xml.sax.SAXException;
2121
import javax.xml.XMLConstants;

grails-console/src/main/groovy/grails/ui/shell/support/GroovyshApplicationContext.groovy

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616
package grails.ui.shell.support
1717

1818
import grails.core.GrailsApplication
19-
import org.apache.groovy.groovysh.Groovysh
19+
import grails.ui.support.DevelopmentWebApplicationContext
20+
import org.codehaus.groovy.tools.shell.Groovysh
2021
import org.codehaus.groovy.tools.shell.IO
2122
import org.springframework.context.support.GenericApplicationContext
2223

24+
2325
/**
2426
* @author Graeme Rocher
2527
* @since 3.0

grails-console/src/main/groovy/grails/ui/shell/support/GroovyshWebApplicationContext.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@ import grails.core.GrailsApplication
1919
import grails.ui.support.DevelopmentWebApplicationContext
2020
import groovy.transform.CompileStatic
2121
import groovy.transform.InheritConstructors
22-
import org.apache.groovy.groovysh.Groovysh
22+
import org.codehaus.groovy.tools.shell.Groovysh
2323
import org.codehaus.groovy.tools.shell.IO
2424

25+
2526
/**
2627
* @author Graeme Rocher
2728
* @since 3.0

grails-core/src/main/groovy/grails/util/AbstractTypeConvertingMap.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package grails.util;
1717

18+
import grails.util.GrailsStringUtils;
1819
import groovy.lang.GroovyObjectSupport;
1920
import org.codehaus.groovy.runtime.DefaultGroovyMethods;
2021
import org.codehaus.groovy.util.HashCodeHelper;

grails-core/src/main/groovy/grails/util/GrailsStringUtils.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ abstract class GrailsStringUtils extends StringUtils{
165165
* Same as {@link StringUtils#isEmpty(java.lang.Object)} but trims the string for surrounding whitespace
166166
*/
167167
static boolean isBlank(String str) {
168-
!hasText(str?.trim())
168+
isEmpty(str?.trim())
169169
}
170170

171171
/**
@@ -179,7 +179,7 @@ abstract class GrailsStringUtils extends StringUtils{
179179
* Opposite of {@link GrailsStringUtils#isEmpty(java.lang.Object)}
180180
*/
181181
static boolean isNotEmpty(String str) {
182-
hasText(str)
182+
!isEmpty(str)
183183
}
184184

185185
/**

grails-core/src/main/groovy/grails/util/GrailsUtil.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,27 @@
1515
*/
1616
package grails.util;
1717

18+
import grails.io.IOUtils;
19+
import groovy.lang.Binding;
20+
import groovy.lang.GroovyShell;
21+
import groovy.lang.Writable;
22+
import groovy.util.slurpersupport.GPathResult;
1823
import org.apache.commons.logging.Log;
1924
import org.apache.commons.logging.LogFactory;
25+
import org.grails.core.io.CachingPathMatchingResourcePatternResolver;
2026
import org.grails.exceptions.reporting.DefaultStackTraceFilterer;
2127
import org.grails.exceptions.reporting.StackTraceFilterer;
28+
import org.springframework.core.io.Resource;
29+
import org.springframework.core.io.UrlResource;
30+
import org.springframework.core.io.support.PathMatchingResourcePatternResolver;
2231

32+
import java.io.IOException;
33+
import java.io.InputStream;
2334
import java.io.PrintWriter;
35+
import java.io.Writer;
36+
import java.net.URL;
37+
import java.util.jar.Attributes;
38+
import java.util.jar.Manifest;
2439

2540
/**
2641
* Grails utility methods for command line and GUI applications.

grails-core/src/main/groovy/org/grails/compiler/injection/GlobalGrailsClassInjectorTransformation.groovy

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ import grails.util.GrailsNameUtils
99
import groovy.transform.CompilationUnitAware
1010
import groovy.transform.CompileDynamic
1111
import groovy.transform.CompileStatic
12+
import groovy.util.slurpersupport.GPathResult
1213
import groovy.xml.MarkupBuilder
1314
import groovy.xml.StreamingMarkupBuilder
14-
import groovy.xml.XmlSlurper
15-
import groovy.xml.slurpersupport.GPathResult
1615
import org.codehaus.groovy.ast.*
1716
import org.codehaus.groovy.ast.expr.ConstantExpression
1817
import org.codehaus.groovy.control.CompilationUnit

grails-core/src/main/groovy/org/grails/core/io/support/GrailsFactoriesLoader.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class GrailsFactoriesLoader extends FactoriesLoaderSupport {
6262
boolean hasArguments = !(arguments != null && arguments.length==0)
6363
List<T> results = new ArrayList<T>()
6464
for(Class<? extends T> clazz : loadFactoryClasses(factoryClass, classLoader)) {
65-
results.add(hasArguments ? clazz.newInstance(arguments) : clazz.getDeclaredConstructor().newInstance())
65+
results.add(hasArguments ? clazz.newInstance(arguments) : clazz.newInstance())
6666
}
6767
OrderComparator.sort((List<?>) results)
6868
results

0 commit comments

Comments
 (0)