Merge branch '2.4.x' of github.com:grails/grails-core into 2.4.x

Author: jeffscottbrown

grails-bootstrap/src/main/groovy/org/codehaus/groovy/grails/cli/fork/ForkedGrailsProcess.groovy

@@ -43,6 +43,7 @@ import org.codehaus.groovy.grails.cli.support.PluginPathDiscoverySupport
 abstract class ForkedGrailsProcess {
 
     public static final String DEBUG_FORK = "grails.debug.fork"
+    public static final String PARENT_PROCESS_PORT = "grails.fork.parent.process.port"
     public static final int DEFAULT_DAEMON_PORT = 8091
     public static final String DEFAULT_DEBUG_ARGS = "-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005"
 
@@ -292,13 +293,13 @@ abstract class ForkedGrailsProcess {
                 if (daemon && !connectedToDaemon) {
                     GrailsConsole.instance.updateStatus("Running without daemon...")
                 }
+
+                startParentAvailabilityServer()
+
                 String classpathString = getBoostrapClasspath(executionContext)
-                String additionalClasspath = System.getProperty('GRAILS_ADDITIONAL_CLASSPATH')
-                if(additionalClasspath) {
-                    classpathString = classpathString + File.pathSeparator + additionalClasspath
-                }
                 List<String> cmd = buildProcessCommand(executionContext, classpathString)
 
+
                 def processBuilder = new ProcessBuilder()
                 processBuilder
                     .directory(executionContext.getBaseDir())
@@ -325,6 +326,21 @@ abstract class ForkedGrailsProcess {
         }
     }
 
+    protected void startParentAvailabilityServer() {
+        if(System.getProperty(PARENT_PROCESS_PORT)) return
+
+        ServerSocket parentAvailabilityServer = new ServerSocket(0)
+        def parentPort = parentAvailabilityServer.localPort
+        System.setProperty(PARENT_PROCESS_PORT, String.valueOf(parentPort))
+        Runtime.addShutdownHook {
+            try {
+                parentAvailabilityServer?.close()
+            } catch (e) {
+                // ignore
+            }
+        }
+    }
+
     @CompileStatic
     protected void runDaemonCommand(String daemonCmd) {
         def clientSocket = new Socket("localhost", daemonPort)
@@ -379,6 +395,8 @@ abstract class ForkedGrailsProcess {
             discoverAndSetAgent(executionContext)
         }
 
+        startParentPortMonitor()
+
         final console = GrailsConsole.instance
         console.updateStatus("Stopping daemon...")
         while(isDaemonRunning()) {
@@ -478,6 +496,11 @@ abstract class ForkedGrailsProcess {
 
     @CompileStatic
     protected List<String> buildProcessCommand(ExecutionContext executionContext, String classpathString, boolean isReserve = false, boolean isDaemon = false) {
+        String additionalClasspath = System.getProperty('GRAILS_ADDITIONAL_CLASSPATH')
+        if(additionalClasspath) {
+            classpathString = classpathString + File.pathSeparator + additionalClasspath
+        }
+
         File tempFile = storeExecutionContext(executionContext)
         final javaHomeEnv = System.getenv("JAVA_HOME")
 
@@ -501,7 +524,12 @@ abstract class ForkedGrailsProcess {
         cmd.addAll(["-Xmx${maxMemory}M".toString(), "-Xms${minMemory}M".toString()])
         if(!(System.getProperty("java.version") =~ /1.[89]./)) {
             cmd.add("-XX:MaxPermSize=${maxPerm}m".toString())
-        } 
+        }
+        def parentPort = System.getProperty(PARENT_PROCESS_PORT)
+        if(parentPort) {
+            cmd << "-D${PARENT_PROCESS_PORT}=${parentPort}".toString()
+        }
+
         cmd.addAll(["-Dgrails.fork.active=true",
             "-Dgrails.build.execution.context=${tempFile.canonicalPath}".toString(), "-cp", classpathString])
 
@@ -744,9 +772,46 @@ abstract class ForkedGrailsProcess {
 
         BuildSettingsHolder.settings = buildSettings
         configureFork(buildSettings)
+        startParentPortMonitor()
+
         buildSettings
     }
 
+    protected void startParentPortMonitor() {
+        def parentProcessPort = System.getProperty(PARENT_PROCESS_PORT)
+        if (parentProcessPort) {
+            Thread.start {
+                def portInt = parentProcessPort.toInteger()
+                while (true) {
+                    sleep(15000)
+                    if (!isServerRunning(portInt)) {
+                        // parent process killed, so bail out too
+                        GrailsConsole.getInstance().addStatus("Parent process shutdown. Exiting...")
+                        System.exit(1)
+                    }
+                }
+            }
+        }
+    }
+
+    /**
+     * @return Whether the server is running
+     */
+    boolean isServerRunning(int port) {
+        Socket socket = null
+        try {
+            socket = new Socket("localhost", port)
+            return socket.isConnected()
+        } catch (e) {
+            return false
+        }
+        finally {
+            try {
+                socket?.close()
+            } catch (Throwable e) {
+            }
+        }
+    }
     protected void configureFork(BuildSettings buildSettings) {
         final runConfig = buildSettings.forkSettings.run
         if (runConfig instanceof Map)