Enforce code style #15016
Merged
Enforce code style #15016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style/formatting checks are executed only by the new workflow, keeping the main pipelines focused on build/test.
matrei
force-pushed
the
enforce-code-style
branch
from
272eeac to
ae2efa2
Compare
To test if reports are uploaded to the workflow summary page.
matrei
force-pushed
the
enforce-code-style
branch
from
945eca0 to
20468a4
Compare
Code style tools (Checkstyle/CodeNarc) generate reports even when clean. Fail fast on style violations instead of continuing and producing pages of reports. Developers can still use `--continue` locally when needed.
This reverts commit 12a1270.
Grails Forge is still using its own Checkstyle rules after this change.
matrei
force-pushed
the
enforce-code-style
branch
from
3aff10e to
ef17c7f
Compare
jdaugherty
approved these changes
Aug 27, 2025
Contributor
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
Can we update DEVELOPMENT.md for the new properties & codestyle workflows?
`-Dorg.gradle.internal.publish.checksums.insecure=true` is no longer required as it is set by the publish plugin by default.
Add info about useful custom Gradle tasks.
Update the section on code style.
jamesfredley
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CodeNarc and Checkstyle Gradle Plugins to enforce code styles.
It adds a Gradle task
codeStyleto run allcodenarc*andcheckstyle*tasks exclusively.It also adds a Gradle property check for
skipCodeStyleto skip code style checking when runningbuildorcheck.Existing GitHub workflows are updated to use this property and a new workflow is added that does only code style checks.