Skip to content

7.0.0 BUG FIX - Application fails if there is an error during index creation #15148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.0.x
Choose a base branch
from
Open

7.0.0 BUG FIX - Application fails if there is an error during index creation #15148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions ...-data-mongodb/core/src/main/groovy/org/grails/datastore/mapping/mongo/MongoDatastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import jakarta.persistence.FlushModeType;

import com.mongodb.MongoClientSettings;
import com.mongodb.MongoCommandException;
import com.mongodb.client.MongoClient;
import com.mongodb.client.MongoIterable;
import com.mongodb.client.model.IndexOptions;
Expand Down Expand Up @@ -846,7 +847,11 @@ protected void initializeIndices(final PersistentEntity entity) {
for (MongoCollection.Index index : indices) {
final Map<String, Object> options = index.getOptions();
final IndexOptions indexOptions = MongoConstants.mapToObject(IndexOptions.class, options);
collection.createIndex(new Document(index.getDefinition()), indexOptions);
try {
collection.createIndex(new Document(index.getDefinition()), indexOptions);
} catch (MongoCommandException e) {
LOG.error("Failed to create index for entity [" + entity.getName() + "] with definition [" + index.getDefinition() + "]: " + e.getMessage(), e);
}
}

for (Map compoundIndex : mappedForm.getCompoundIndices()) {
Expand All @@ -859,11 +864,15 @@ protected void initializeIndices(final PersistentEntity entity) {
}
}
Document indexDef = new Document(compoundIndex);
if (indexAttributes != null) {
final IndexOptions indexOptions = MongoConstants.mapToObject(IndexOptions.class, indexAttributes);
collection.createIndex(indexDef, indexOptions);
} else {
collection.createIndex(indexDef);
try {
if (indexAttributes != null) {
final IndexOptions indexOptions = MongoConstants.mapToObject(IndexOptions.class, indexAttributes);
collection.createIndex(indexDef, indexOptions);
} else {
collection.createIndex(indexDef);
}
} catch (MongoCommandException e) {
LOG.error("Failed to create compound index for entity [" + entity.getName() + "] with definition [" + indexDef + "]: " + e.getMessage(), e);
}
}
}
Expand All @@ -889,11 +898,15 @@ protected void initializeIndices(final PersistentEntity entity) {
}
}
// continue using deprecated method to support older versions of MongoDB
if (options.isEmpty()) {
collection.createIndex(dbObject);
} else {
final IndexOptions indexOptions = MongoConstants.mapToObject(IndexOptions.class, options);
collection.createIndex(dbObject, indexOptions);
try {
if (options.isEmpty()) {
collection.createIndex(dbObject);
} else {
final IndexOptions indexOptions = MongoConstants.mapToObject(IndexOptions.class, options);
collection.createIndex(dbObject, indexOptions);
}
} catch (MongoCommandException e) {
LOG.error("Failed to create index for entity [" + entity.getName() + "] on property [" + property.getName() + "]: " + e.getMessage(), e);
}
}
}
Expand Down
Loading