fix: copy missing fields in AbstractDetachedCriteria.clone()

[jamesfredley]

Summary

• AbstractDetachedCriteria.clone() was missing connectionName, lazyQuery, and associationCriteriaMap
• This caused withConnection() settings to be silently lost when chained methods like max(), offset(), or sort() were called afterward, because each internally clones the criteria

Example of the bug

def criteria = Product.where { amount > 100 }
    .withConnection('secondary')
    .max(10)  // clones internally, loses connectionName

criteria.list()  // queries DEFAULT datasource instead of 'secondary'

Changes

• AbstractDetachedCriteria.clone(): Added copying of connectionName, lazyQuery, and associationCriteriaMap (as a shallow copy)
• DetachedCriteriaCloneSpec: 7 new unit tests verifying clone preserves all fields, creates independent map copies, and that withConnection().max() chaining works correctly

Test Results

• DetachedCriteriaCloneSpec: 7/7 pass
• codeStyle: pass

Fixes #15422

Reproducer: https://github.com/jamesfredley/grails-detachedcriteria-clone-connection

[Copilot]

Pull request overview

This PR fixes a critical bug in AbstractDetachedCriteria.clone() where three instance fields (connectionName, lazyQuery, and associationCriteriaMap) were not being copied during cloning. This caused withConnection() datasource routing settings to be silently lost when chained with other criteria methods like max(), offset(), or sort(), resulting in queries being executed against the wrong datasource.

Changes:

• Added copying of connectionName, lazyQuery, and associationCriteriaMap fields in AbstractDetachedCriteria.clone()
• Created comprehensive unit test suite with 7 tests verifying clone behavior for all newly copied fields

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/query/criteria/AbstractDetachedCriteria.groovy	Added 3 lines to clone() method to copy connectionName, lazyQuery, and associationCriteriaMap fields
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/query/criteria/DetachedCriteriaCloneSpec.groovy	New test file with 7 unit tests verifying clone preserves all required fields and creates independent copies where needed

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.