Revert classpath scanning change, use the same strategy as grails-core #1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spoke to @jamesfredley and we decided to revert the initial change - there were further issues on the Spring side that didn't look fixed until 6.1.7.
This also lead to the discovery that AnnotationMetdataReader is copied from grails-core. Hence, this pull request will copy the deprecated spring classes as well. Worse, there's even an ASM bug fix on the data-mapping side, that isn't in the core side.
Long term we need a base support project that can be shared between grails & gorm, but that is out of scope for now. I'll bring this up in our weekly meeting.