Multiple Project updates #1868
Merged
Multiple Project updates #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add descriptive job names for better output readability. - Use explicit runner version: `ubuntu-24.04` - Update step names with emojis for clarity. - Replace `GRADLE_ENTERPRISE_ACCESS_KEY` with `DEVELOCITY_ACCESS_KEY`. - Remove unused remote build cache authentication variables. - Add `GITHUB_MAVEN_PASSWORD` for GitHub packages staging repos where missing. - Pin version of third-party action: `ben-uk/workflow-dispatch`. - Add Gradle `--continue` to output all potential errors. - Add Gradle `--no-build-cache` during publishing to avoid using stale cache issues. - Grant `packages: read` permission for GitHub packages (e.g., Grails staging repos). - Simplify `release-notes.yml` by removing unnecessary config checks.
- Replace custom aggregate test report implementation. - Use `test-report-aggregation` plugin for a simpler and more maintainable solution. - Reference: [Test Report Aggregation Plugin Documentation](https://docs.gradle.org/current/userguide/test_report_aggregation_plugin.html)
The `idea` plugin is no longer required and has been removed to simplify the build script.
- Bump version from `2.0.2` to `2.1`. - [Release Notes](https://github.com/gradle/common-custom-user-data-gradle-plugin/releases/tag/v2.1)
- Change incorrect tag `grails-gsp` to `grails-data-mapping`.
- Groovy version is now sourced from `grails-bom`, making the property redundant.
- All projects now use a unified version sourced from `projectVersion`, rendering the guard obsolete.
- Fixed a typo in Puneet's developer ID
- Use `.configureEach` where applicable for lazy configuration. - Standardize string usage with single quotes. - Use lifecycle logger instead of `System.out.println` for better logging. - Address various Gradle deprecations.
- Configure logging for events: passed, skipped and failed.
- Define a `clean` task in the root project to simplify build cleanup.
- Explicitly add all direct dependencies to enhance stability (reduce reliance on transitive dependencies). - Set the correct scope for project dependencies. - Optionally exclude unnecessary transitive API dependencies to ensure accurate testing of dependency chains. - Add comments to clarify why and in which scope each dependency is used.
- Clean up test code by removing an unused method, eliminating the dependency on `jakarta.annotation:jakarta.annotation-api` in this class.
- Update usages of `BeanUtils.instantiate` to the non-deprecated `BeanUtils.instantiateClass`.
…xtension` - Refactor code to implement the `IGlobalExtension` interface, replacing the deprecated `AbstractGlobalExtension` class.
- Use `@PendingFeature` so that the build fails if the test unexpectedly succeeds, providing an alert that the test passes.
- The `HasManyDefaultMappedBySpec` test now passes, so the `@Ignore` annotation is no longer needed.
- Update tests to use the `@Suite` annotation, replacing the deprecated `@RunWith`.
…xception` - Update code to use `SecurityException` instead of the deprecated `AccessControlException`.
- Update year and set copyright holder to "the original author or authors." - Change the license link to use `https`.
- Resolve issues with building using a Groovy snapshot version. - Explicitly override the Groovy version in the build when requested, as it is now sourced from grails-bom instead of a property.
- Remove space
jdaugherty
reviewed
Jan 23, 2025
Previously, some tests in the TCK were marked with `@Ignored`. This commit replaces `@Ignored` with `@PendingFeatureIf`, using system property conditions to enable selective execution. This approach ensures tests are only skipped when necessary, improving test coverage and flexibility.
Update the CI configuration to include a build matrix for Java versions 17 and 21. This ensures compatibility and proper testing across multiple supported Java versions.
Re-add the `groovy-test-junit5` dependency to ensure JUnit 5 tests execute correctly.
…mpileClasspath Switch from `compileOnly` to `compileOnlyApi` to ensure that the `DelegateAsync` AST transformation classes are available on the downstream `compileClasspath`.
The test `WhereMethodSpec."Test rlike query"` was previously annotated with `@Ignore`, but it is passing. The comment that "rlike not supported by all datastores yet" should not be relevant, as this test runs exclusively in the `grails-datastore-gorm-test` project where it passes successfully.
jdaugherty
reviewed
Jan 25, 2025
| if: success() | ||
| uses: grails/github-actions/post-release@main | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
Contributor
There was a problem hiding this comment.
Isn't the token so we can close out milestones, etc? I'm ok leaving this out for now, but we probably should talk to the team how we want to handle closing out projects, etc.
Contributor
Author
There was a problem hiding this comment.
The token argument defaults to github.token, so we don't have to set it explicitly:
https://github.com/grails/github-actions/blob/15e3017e73c5c4bfdc02c36792da171418da563f/post-release/action.yml#L7
jdaugherty
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several updates across multiple projects. Please refer to the individual commit messages for detailed descriptions of the changes.
apache/grails-gradle-plugin#394 is needed for publishing to work.